Repository navigation
Fix Anima text encoder exports and standalone core denoising - #14943
Conversation
|
Hi @lucasruan1618, thanks for the PR! It does not appear to link an issue it fixes. If this PR addresses an existing issue, please add a closing keyword (e.g. Please note that PRs without a linked issue are likely to be automatically closed 10 days after this notice. Once the PR links an issue (or gets the |
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Fix Anima text encoder exports and standalone core denoising
What does this PR do?
Fixes two issues when running Anima's modular stages as separate pipelines.
AnimaTextEncoderStepproduces eight Qwen/T5 conditioning tensors, but none is tagged withkwargs_type="denoiser_input_fields". Consequently, the documented split-pipeline workflow:exports an empty dictionary and fails with
Required input 'qwen_prompt_embeds' is missing. This PR adds the tag to all eight outputs, applying the same fix pattern as #14925.Separately,
AnimaCoreDenoiseStepdoes not require a VAE, but latent preparation readsvae_scale_factor, whose property accessesself.vaedirectly. Running that block standalone therefore raisesAttributeError: 'AnimaModularPipeline' object has no attribute 'vae_scale_factor'. This PR allows the property to return its existing default of 8 when the VAE component is absent. Pipelines with a VAE continue to use its configured scale factor.The source changes are eight output tags and one component lookup. Regression tests cover split execution with omitted, empty, and non-empty negative prompts, comparing generated images against the complete pipeline. A separate test passes encoded tensors by name to the standalone core denoiser and checks the resulting latent shape and finite values.
Validation
TestBlockKwargsTypeInputstests: 4 passed.make style,make fix-copies,make quality, andgit diff --check: passed.Tests use real components from
hf-internal-testing/tiny-anima-modular-pipe. Production-size checkpoints were not tested.Self-review notes
Reviewed against
.ai/references/review-rules.md,code_style.md,modular.md, andtesting.md, following.ai/skills/self-review.Before submitting
Who can review?
@yiyixuxu